Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Moves spec files to the src folder - iteration 7 #16943

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Moves spec files to the src folder - iteration 7
  • Organizes the SqlLab component structure
  • Standardizes the extension of the test files

This work is part of SIP-61

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #16943 (dc8809d) into master (6225c9a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head dc8809d differs from pull request most recent head c39d154. Consider uploading reports for the commit c39d154 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16943      +/-   ##
==========================================
+ Coverage   76.90%   76.91%   +0.01%     
==========================================
  Files        1024     1025       +1     
  Lines       54931    54951      +20     
  Branches     7486     7488       +2     
==========================================
+ Hits        42246    42267      +21     
+ Misses      12437    12436       -1     
  Partials      248      248              
Flag Coverage Δ
javascript 71.06% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/SqlLab/components/AceEditorWrapper/index.tsx 58.75% <ø> (ø)
...erset-frontend/src/SqlLab/components/App/index.jsx 57.14% <ø> (ø)
...tend/src/SqlLab/components/ColumnElement/index.tsx 95.45% <ø> (ø)
...qlLab/components/EstimateQueryCostButton/index.jsx 20.83% <ø> (ø)
...lLab/components/ExploreCtasResultsButton/index.jsx 7.69% <ø> (ø)
...c/SqlLab/components/ExploreResultsButton/index.jsx 92.00% <ø> (ø)
...d/src/SqlLab/components/QueryAutoRefresh/index.jsx 65.90% <ø> (ø)
...c/SqlLab/components/RunQueryActionButton/index.tsx 65.11% <ø> (ø)
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 88.23% <ø> (ø)
...frontend/src/SqlLab/components/SaveQuery/index.tsx 75.55% <ø> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6225c9a...c39d154. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the improvement!

@michael-s-molina michael-s-molina merged commit 1ab36c9 into apache:master Oct 4, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants