Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: versioned _export Stable #16569

Closed
wants to merge 4 commits into from
Closed

Conversation

amitmiran137
Copy link
Member

SUMMARY

VERSIONED_EXPORT Stable

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@amitmiran137 amitmiran137 changed the title Version export ff on docs: versioned _export Stable Sep 2, 2021
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #16569 (c86bf9e) into master (4f0074a) will increase coverage by 9.94%.
The diff coverage is n/a.

❗ Current head c86bf9e differs from pull request most recent head 7cfae9a. Consider uploading reports for the commit 7cfae9a to get more accurate results

@@            Coverage Diff             @@
##           master   #16569      +/-   ##
==========================================
+ Coverage   66.77%   76.71%   +9.94%     
==========================================
  Files        1667     1002     -665     
  Lines       64362    53801   -10561     
  Branches     6495     7284     +789     
==========================================
- Hits        42978    41276    -1702     
+ Misses      19701    12285    -7416     
+ Partials     1683      240    -1443     
Flag Coverage Δ
javascript 71.00% <ø> (+19.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.36% <ø> (-0.47%) ⬇️
...ntend/src/explore/components/ExploreChartPanel.jsx 15.00% <0.00%> (-57.00%) ⬇️
superset/db_engine_specs/__init__.py 50.00% <0.00%> (-38.47%) ⬇️
...tend/src/filters/components/Select/controlPanel.ts 61.53% <0.00%> (-38.47%) ⬇️
...-frontend/src/visualizations/presets/MainPreset.js 80.00% <0.00%> (-20.00%) ⬇️
...s/controls/MetricControl/MetricDefinitionValue.jsx 80.00% <0.00%> (-20.00%) ⬇️
...nd/src/dashboard/util/buildFilterScopeTreeEntry.js 73.68% <0.00%> (-17.23%) ⬇️
...ontrols/DndColumnSelectControl/DndMetricSelect.tsx 41.40% <0.00%> (-17.12%) ⬇️
superset-frontend/src/dataMask/actions.ts 38.88% <0.00%> (-15.66%) ⬇️
...c/dashboard/components/dnd/AddSliceDragPreview.jsx 35.71% <0.00%> (-14.29%) ⬇️
... and 1631 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0074a...7cfae9a. Read the comment docs.

@srinify
Copy link
Contributor

srinify commented Mar 18, 2022

Approved since VERSIONED_EXPORT is now enabled by default in config.py!

@sfirke
Copy link
Member

sfirke commented Sep 1, 2023

Sorry this sat unattended for so long 😔 I believe this is now obsolete as both of its changes are covered already in the repo:

I'll close it given that. Please ping me if that's incorrect.

@sfirke sfirke closed this Sep 1, 2023
@mistercrunch mistercrunch deleted the version_export_ff_on branch March 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants