Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native-filters): add sort metric to select #14590

Merged
merged 1 commit into from
May 12, 2021

Conversation

villebro
Copy link
Member

SUMMARY

Some databases require including the sort metrics in the select. To maximise database compatibility and make it possible to add tooltips to show the metric value used (later PR), we add the metric to the select filter.

TEST PLAN

CI + new tests added

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro force-pushed the villebro/sort-metric-2 branch 4 times, most recently from d5b9228 to 71aff47 Compare May 12, 2021 13:39
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #14590 (b9b2aff) into master (6d786d4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14590      +/-   ##
==========================================
+ Coverage   77.40%   77.42%   +0.01%     
==========================================
  Files         958      958              
  Lines       48329    48330       +1     
  Branches     5679     5680       +1     
==========================================
+ Hits        37410    37420      +10     
+ Misses      10719    10710       -9     
  Partials      200      200              
Flag Coverage Δ
javascript 72.51% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/filters/components/Select/buildQuery.ts 100.00% <100.00%> (+75.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d786d4...b9b2aff. Read the comment docs.

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works good. Thank you!

@villebro villebro merged commit f1c32b9 into apache:master May 12, 2021
amitmiran137 pushed a commit that referenced this pull request May 13, 2021
serenajiang pushed a commit to airbnb/superset-fork that referenced this pull request May 17, 2021
@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label May 28, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Sep 8, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🍒 1.2.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard preset-io size/M v1.2 🍒 1.2.0 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants