Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update default cron settings for new alerts and reports #14363

Merged

Conversation

samtfm
Copy link
Contributor

@samtfm samtfm commented Apr 27, 2021

SUMMARY

Updates default cron settings in the Add Alert and Add Report modals from "every minute" to "every hour"

rationale:

Preset users are setting alerts at a higher frequency than expected, which is sometimes causing issues with queuing and the system getting backed up.
Setting the default schedule to a less frequent cadence may help set the users expectation that the alerts aren't meant to be set up to be checking every minute.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before:
Screen Shot 2021-04-26 at 5 23 04 PM

after:
Screen Shot 2021-04-26 at 5 23 21 PM

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #14363 (22d4f7a) into master (4fbb572) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14363   +/-   ##
=======================================
  Coverage   77.14%   77.14%           
=======================================
  Files         954      954           
  Lines       48136    48136           
  Branches     5986     5986           
=======================================
  Hits        37133    37133           
  Misses      10806    10806           
  Partials      197      197           
Flag Coverage Δ
javascript 72.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 61.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fbb572...22d4f7a. Read the comment docs.

@lilykuang lilykuang merged commit 6898dd9 into apache:master Apr 27, 2021
@lilykuang lilykuang deleted the samtfm/update-default-alert-schedule branch April 27, 2021 15:03
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants