fix(native-filters): allowClear only when required not checked #14353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabryje
reviewed
Apr 26, 2021
superset-frontend/src/filters/components/Select/controlPanel.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #14353 +/- ##
==========================================
- Coverage 77.18% 77.14% -0.04%
==========================================
Files 954 954
Lines 48134 48140 +6
Branches 5985 5987 +2
==========================================
- Hits 37151 37139 -12
- Misses 10786 10804 +18
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
junlincc
added
the
dashboard:native-filters
amitmiran137
pushed a commit
that referenced
this pull request
Apr 27, 2021
* fix(native-filters): allowClear only when required not checked * Update superset-frontend/src/filters/components/Select/controlPanel.ts Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> (cherry picked from commit 8a0d321)
amitmiran137
pushed a commit
that referenced
this pull request
Apr 28, 2021
* fix(native-filters): allowClear only when required not checked * Update superset-frontend/src/filters/components/Select/controlPanel.ts Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> (cherry picked from commit 8a0d321)
11 tasks
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…e#14353) * fix(native-filters): allowClear only when required not checked * Update superset-frontend/src/filters/components/Select/controlPanel.ts Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Rephrase "Allow empty filter" to be inline with Filter Box "Required" control. Also change behavior so that
allowClearis set to false when "Required" is set to true.The control has been renamed and the description updated:
When in the dashboard view, the selection can't be cleared when in single select mode:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION