Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alert/report): update content format radio buttons #14235

Merged
merged 3 commits into from
Apr 26, 2021

Conversation

lilykuang
Copy link
Member

SUMMARY

  • organizing radio buttons in alert/report modal vertically to create a tree structure

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

AFTER:
Screen Shot 2021-04-19 at 10 59 21 AM
Screen Shot 2021-04-19 at 10 59 28 AM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang force-pushed the lily/update-report-alert-modal-ui branch from 275dfa8 to 97b93b9 Compare April 19, 2021 18:07
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #14235 (f125c3c) into master (7ff35df) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14235      +/-   ##
==========================================
- Coverage   77.18%   77.14%   -0.04%     
==========================================
  Files         954      954              
  Lines       48134    48144      +10     
  Branches     5985     5987       +2     
==========================================
- Hits        37151    37143       -8     
- Misses      10786    10804      +18     
  Partials      197      197              
Flag Coverage Δ
javascript 72.03% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 61.70% <100.00%> (+0.37%) ⬆️
...d/src/dashboard/components/FiltersBadge/Styles.tsx 54.05% <0.00%> (-43.25%) ⬇️
...src/dashboard/components/FiltersBadge/selectors.ts 76.92% <0.00%> (-1.65%) ⬇️
...nd/src/dashboard/components/FiltersBadge/index.tsx 100.00% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ff35df...f125c3c. Read the comment docs.

@robdiciuccio
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@robdiciuccio Ephemeral environment spinning up at http://34.219.111.2:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@lilykuang lilykuang force-pushed the lily/update-report-alert-modal-ui branch from 98e6065 to f125c3c Compare April 26, 2021 15:21
@lilykuang lilykuang merged commit 8767798 into apache:master Apr 26, 2021
@lilykuang lilykuang deleted the lily/update-report-alert-modal-ui branch April 26, 2021 18:33
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* update content format selection ui

* translations

* update test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants