-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: publish superset helm chart #14163
Conversation
Thank you so much for your contribution!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After taking a closer look, I think we need a few tweaks
Has this been tested? I was going to be submitting a nearly identical PR. I ran into some issues when creating my action. Namely I needed to add the upstream chart repos to the released action. You can see what I did and copy that over if you want: Also, is it the intent to publish a new chart on every PR merge? I would assume you only publish a new chart of you have modified the existing charts. You can add: paths:
- 'helm/**' To make this action trigger on only modifications to the charts. |
waiting this |
@craig-rueda Should be good now. |
Can you also make a dummy change to something in the chart so we can see the linter working? |
Done. However I don't think new tests in a PR are run, they need to be in master if I'm not wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. Let's try it.
@craig-rueda on standby : ) |
Looks like it failed: https://github.com/apache/superset/actions/runs/756228516 |
Yes it did. Seems you have policies on what actions can run in your repo. Let me check. |
I'll open a ticket with Apache Infra and see if I can get it allow-listed |
Thank you! |
@craig-rueda Once you do, we'll probably need to update the documentation to point users to |
* Create initial helm-release action for superset * Add lintconf to ensure chart passes validation * Add lint-test job * Add apache licence headers * Run job for master only * Move helm-lint to separate workflow * Helm release for master & helm dir changes only * Dummy change to test linter
SUMMARY
This PR adds a simple chart releaser action to package and publish the superset helm chart.
A chart release will be created with the name
superset-helm-chart-{{version}}
The chart repo will be available at https://apache.github.io/superset
A user will only need to run the following to install superset as opposed to cloning the entire repository.
helm repo add superset https://apache.github.io/superset
helm install superset/superset
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Clone the repo.
ADDITIONAL INFORMATION
@amitmiran137