Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: invalid hostname and password error messages (Redshift) #14111

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

AAfghahi
Copy link
Member

SUMMARY

Capture the most common error messages in Redshift, and return them to the user. This is used when first making a DB.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Untitled

TEST PLAN

Added Unit tests

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@AAfghahi
Copy link
Member Author

🏷️ ready-to-merge

@betodealmeida
Copy link
Member

🏷️ #ready-to-merge

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #14111 (fb8d02a) into master (cfe927b) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head fb8d02a differs from pull request most recent head 60f24fc. Consider uploading reports for the commit 60f24fc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14111      +/-   ##
==========================================
- Coverage   79.55%   79.38%   -0.17%     
==========================================
  Files         944      944              
  Lines       47871    47852      -19     
  Branches     6045     6045              
==========================================
- Hits        38082    37987      -95     
- Misses       9668     9744      +76     
  Partials      121      121              
Flag Coverage Δ
cypress 56.40% <ø> (+0.02%) ⬆️
hive ?
mysql 80.75% <100.00%> (+<0.01%) ⬆️
postgres 80.76% <100.00%> (?)
python 80.81% <100.00%> (-0.33%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/redshift.py 93.75% <100.00%> (+6.25%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 74.42% <0.00%> (-16.42%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/models/dashboard.py 71.85% <0.00%> (-2.57%) ⬇️
superset/db_engine_specs/presto.py 81.79% <0.00%> (-2.31%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/result_set.py 96.77% <0.00%> (-1.62%) ⬇️
superset/db_engine_specs/base.py 86.54% <0.00%> (-0.90%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfe927b...60f24fc. Read the comment docs.

@eschutho
Copy link
Member

🏷 ready-to-merge

@superset-github-bot superset-github-bot bot added the need:merge The PR is ready to be merged label Apr 14, 2021
@betodealmeida
Copy link
Member

🏷 ready-to-merge

What magic is this?!?

@betodealmeida betodealmeida merged commit 321db46 into apache:master Apr 14, 2021
@AAfghahi
Copy link
Member Author

🏷 ready-to-merge

What magic is this?!?

I made this helpful graphic about what happened:
p08p1fy1

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
…#14111)

* custom errors for redshift

* added unit tests and custom errors
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged size/L 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants