-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: error messages when connecting to MSSQL #14093
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14093 +/- ##
==========================================
+ Coverage 79.72% 79.73% +0.01%
==========================================
Files 942 942
Lines 47709 47729 +20
Branches 6009 6009
==========================================
+ Hits 38035 38057 +22
+ Misses 9553 9551 -2
Partials 121 121
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
172110b
to
32ca6cd
Compare
32ca6cd
to
f8bb103
Compare
TEST_CONNECTION_PORT_CLOSED_REGEX = re.compile( | ||
r"Net-Lib error during Connection refused \(61\)" | ||
) | ||
TEST_CONNECTION_HOST_DOWN_REGEX = re.compile( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we only going to use these errors for test connection, or will we be using them for database creation as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use them for both. Anytime we have a DBAPI
exception we can call extract_errors
to get these errors.
* feat: error messages when connecting to MSSQL * Address comments
SUMMARY
Add better error messages when connecting to MSSQL.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Added unit tests and tested locally (see screenshots).
ADDITIONAL INFORMATION