-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update outdated country map tools instructions #14027
Conversation
For some reason I couldn't get the local doc builds to work.
@pkdotson , have you seen this error before? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docs! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #14027 +/- ##
==========================================
- Coverage 79.30% 79.14% -0.16%
==========================================
Files 938 940 +2
Lines 47523 47605 +82
Branches 5940 5979 +39
==========================================
- Hits 37687 37679 -8
- Misses 9710 9800 +90
Partials 126 126
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
also add actionable error for country map vis
also add actionable error for country map vis
SUMMARY
Update the Country Map Tools doc to reflect the new process of adding a country map.
Also removed redundant information about ISO codes to make the docs easier to read (added a link to Wikipedia for anyone interested).
Also updated error handling in viz.py for country map to give more actionable errors.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TEST PLAN
CI and verify docs site locally