Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update outdated country map tools instructions #14027

Merged
merged 2 commits into from
Apr 9, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Apr 8, 2021

SUMMARY

Update the Country Map Tools doc to reflect the new process of adding a country map.

Also removed redundant information about ISO codes to make the docs easier to read (added a link to Wikipedia for anyone interested).

Also updated error handling in viz.py for country map to give more actionable errors.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

before

After

after

TEST PLAN

CI and verify docs site locally

@ktmud
Copy link
Member Author

ktmud commented Apr 8, 2021

For some reason I couldn't get the local doc builds to work.

        
success run static queries - 3.785s - 5/5 1.32/s
success run page queries - 0.073s - 125/125 1717.76/s
error Generating development JavaScript bundle failed

JSON5: invalid end of input at 1:1
Occurred while linting /Users/jesse_yang/projects/superset-fork/docs/src/pages/404.jsx:22
failed Building development bundle - 33.582s
success building schema - 3.975s

@pkdotson , have you seen this error before?

@junlincc junlincc requested a review from pkdotson April 8, 2021 17:25
@ktmud ktmud force-pushed the country-map-docs branch from 9da3c22 to 66e4d34 Compare April 8, 2021 19:37
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs! 🚀

docs/src/pages/docs/Miscellaneous/index.mdx Outdated Show resolved Hide resolved
docs/src/pages/docs/Miscellaneous/index.mdx Outdated Show resolved Hide resolved
docs/src/pages/docs/Miscellaneous/index.mdx Outdated Show resolved Hide resolved
docs/src/pages/docs/Miscellaneous/index.mdx Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 9, 2021
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktmud ktmud force-pushed the country-map-docs branch from 296f235 to c996438 Compare April 9, 2021 16:57
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 9, 2021
@ktmud ktmud force-pushed the country-map-docs branch from c996438 to 0ebcf74 Compare April 9, 2021 16:57
@ktmud ktmud force-pushed the country-map-docs branch from 0ebcf74 to 0e6ddb4 Compare April 9, 2021 17:14
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #14027 (395a003) into master (2c96c5b) will decrease coverage by 0.15%.
The diff coverage is 52.38%.

❗ Current head 395a003 differs from pull request most recent head 0e6ddb4. Consider uploading reports for the commit 0e6ddb4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14027      +/-   ##
==========================================
- Coverage   79.30%   79.14%   -0.16%     
==========================================
  Files         938      940       +2     
  Lines       47523    47605      +82     
  Branches     5940     5979      +39     
==========================================
- Hits        37687    37679       -8     
- Misses       9710     9800      +90     
  Partials      126      126              
Flag Coverage Δ
cypress 56.06% <ø> (+<0.01%) ⬆️
hive ?
mysql 80.71% <52.38%> (-0.01%) ⬇️
postgres 80.75% <52.38%> (-0.01%) ⬇️
presto 80.46% <52.38%> (?)
python 81.04% <52.38%> (-0.12%) ⬇️
sqlite 80.35% <52.38%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/dashboard/components/SliceHeader/index.tsx 41.02% <ø> (ø)
...dashboard/components/menu/ShareMenuItems/index.tsx 25.00% <ø> (ø)
superset/viz.py 55.65% <0.00%> (-0.26%) ⬇️
superset/charts/api.py 81.81% <100.00%> (+0.51%) ⬆️
superset/exceptions.py 100.00% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
...c/filters/components/Select/SelectFilterPlugin.tsx 50.00% <0.00%> (-30.96%) ⬇️
superset/db_engine_specs/hive.py 74.42% <0.00%> (-16.42%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff08d42...0e6ddb4. Read the comment docs.

@ktmud ktmud merged commit fe08b69 into apache:master Apr 9, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
also add actionable error for country map vis
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
also add actionable error for country map vis
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels release:note size/L 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants