Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use cross-env when running dev-server #13743

Merged
merged 2 commits into from
Mar 24, 2021
Merged

feat: use cross-env when running dev-server #13743

merged 2 commits into from
Mar 24, 2021

Conversation

cemremengu
Copy link
Contributor

@cemremengu cemremengu commented Mar 23, 2021

Use cross-env when running dev-server so inline ENV variables can be set on windows

@request-info
Copy link

request-info bot commented Mar 23, 2021

We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the title or description empty.

@request-info request-info bot added the need:more-info Requires more information from author label Mar 23, 2021
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #13743 (76e534d) into master (5b79f84) will increase coverage by 0.01%.
The diff coverage is 77.03%.

❗ Current head 76e534d differs from pull request most recent head 30dab62. Consider uploading reports for the commit 30dab62 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13743      +/-   ##
==========================================
+ Coverage   77.45%   77.47%   +0.01%     
==========================================
  Files         933      933              
  Lines       47144    47186      +42     
  Branches     5848     5872      +24     
==========================================
+ Hits        36516    36555      +39     
- Misses      10485    10489       +4     
+ Partials      143      142       -1     
Flag Coverage Δ
javascript 63.53% <77.03%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/chart/chartReducer.ts 66.19% <ø> (+1.81%) ⬆️
superset-frontend/src/dashboard/index.jsx 100.00% <ø> (+36.36%) ⬆️
...tasourcePanel/DatasourcePanelDragWrapper/index.tsx 100.00% <ø> (ø)
superset-frontend/src/explore/index.jsx 100.00% <ø> (+36.36%) ⬆️
superset-frontend/src/chart/chartAction.js 78.60% <60.00%> (+0.60%) ⬆️
superset-frontend/src/middleware/asyncEvent.ts 78.03% <77.69%> (-9.32%) ⬇️
...set-frontend/src/dashboard/util/getDropPosition.js 90.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b79f84...30dab62. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

This seems good, although we don't officially support Windows it's probably a good change to make

@cemremengu
Copy link
Contributor Author

@etr2460 should we add it to other commands like cover for consistency?

@nytai
Copy link
Member

nytai commented Mar 23, 2021

@cemremengu Yes, let's add it to all commands with inline env vars

@junlincc junlincc added the need:merge The PR is ready to be merged label Mar 23, 2021
@etr2460
Copy link
Member

etr2460 commented Mar 23, 2021

Yup, agreed! Let's wait to merge until it's added everywhere

@betodealmeida betodealmeida removed the need:merge The PR is ready to be merged label Mar 23, 2021
@cemremengu cemremengu requested a review from etr2460 March 24, 2021 06:59
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome, thanks!

@etr2460 etr2460 merged commit ff0c9e9 into apache:master Mar 24, 2021
@cemremengu cemremengu deleted the patch-1 branch March 24, 2021 16:40
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
* feat: use cross-env when running dev-server

* use cross-env for other inline env vars
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:more-info Requires more information from author size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants