-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use cross-env when running dev-server #13743
Conversation
We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the |
Codecov Report
@@ Coverage Diff @@
## master #13743 +/- ##
==========================================
+ Coverage 77.45% 77.47% +0.01%
==========================================
Files 933 933
Lines 47144 47186 +42
Branches 5848 5872 +24
==========================================
+ Hits 36516 36555 +39
- Misses 10485 10489 +4
+ Partials 143 142 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
This seems good, although we don't officially support Windows it's probably a good change to make
@etr2460 should we add it to other commands like |
@cemremengu Yes, let's add it to all commands with inline env vars |
Yup, agreed! Let's wait to merge until it's added everywhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks awesome, thanks!
* feat: use cross-env when running dev-server * use cross-env for other inline env vars
Use cross-env when running dev-server so inline ENV variables can be set on windows