Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Add optional apt-get install to superset_bootstrap.sh #13678

Merged
merged 2 commits into from
Mar 18, 2021
Merged

feat(helm): Add optional apt-get install to superset_bootstrap.sh #13678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fc30b8
add conditional apt install
danielewood Mar 17, 2021
8b21299
move install switch to correct command.
danielewood Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions helm/superset/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,17 @@ Create chart name and version as used by the chart label.
{{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" -}}
{{- end -}}

{{- define "superset-bootstrap" }}
{{- define "superset-bootstrap" -}}
#!/bin/sh

{{ if .Values.additionalAptPackages }}
apt-get update -y \
&& apt-get install -y --no-install-recommends \
{{ range .Values.additionalAptPackages }}{{ . }} {{ end }}\
&& rm -rf /var/lib/apt/lists/*
{{ end -}}
{{ if .Values.additionalRequirements }}
pip install {{ range .Values.additionalRequirements }}{{ . }} {{ end }}

{{ end -}}
{{ end -}}

{{- define "superset-config" }}
Expand Down
4 changes: 4 additions & 0 deletions helm/superset/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ additionalRequirements:
- "psycopg2==2.8.5"
- "redis==3.2.1"

## These apt packages are applied on init of superset containers
additionalAptPackages: {}
# - nano

## The name of the secret which we will use to generate a superset_config.py file
## Note: this secret must have the key superset_config.py in it and can include other files as well
##
Expand Down