docs: deprecate old alerts and dash/charts reports #13440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
changed the title
nytai
approved these changes
Mar 3, 2021
willbarrett
reviewed
Mar 3, 2021
superset/config.py
Outdated
| @@ -614,18 +615,8 @@ class CeleryConfig: # pylint: disable=too-few-public-methods | |||
| CELERY_ACKS_LATE = False | |||
| CELERY_ANNOTATIONS = { | |||
| "sql_lab.get_sql_results": {"rate_limit": "100/s"}, | |||
There was a problem hiding this comment.
I think these removals break SEMVER - we shouldn't change the defaults for the configuration between majors. Let's keep the schedules, but perhaps add a deprecation?
willbarrett
reviewed
Mar 3, 2021
| EMAIL_ASYNC_TIME_LIMIT_SEC = 300 | ||
|
|
||
| # Email report configuration | ||
| # From address in emails | ||
| EMAIL_REPORT_FROM_ADDRESS = "reports@superset.org" |
There was a problem hiding this comment.
Same comment with these config removals.
There was a problem hiding this comment.
This one is used anywhere, safe to just remove
willbarrett
approved these changes
Mar 3, 2021
Codecov Report
@@ Coverage Diff @@
## master #13440 +/- ##
==========================================
- Coverage 72.69% 71.71% -0.98%
==========================================
Files 903 804 -99
Lines 45611 40651 -4960
Branches 5501 4159 -1342
==========================================
- Hits 33156 29153 -4003
+ Misses 12243 11498 -745
+ Partials 212 0 -212
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@dpgaspar looks like this just needs a lint fix. |
dpgaspar
deleted the
danielgaspar/ch6091/add-additional-deprecation-notices-to-the
branch
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* docs: deprecated old alerts and dash/charts reports * revert celery default config * fix lint
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Deprecates the old alerts and reports feature
ADDITIONAL INFORMATION