-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(release): pin pyjwt to version <2 #12804
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12804 +/- ##
==========================================
- Coverage 67.01% 63.40% -3.61%
==========================================
Files 1022 488 -534
Lines 50100 30138 -19962
Branches 5065 0 -5065
==========================================
- Hits 33573 19109 -14464
+ Misses 16403 11029 -5374
+ Partials 124 0 -124
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to pin all our main dependencies under the next major
Yes, we should give poetry another try
After some more research, I believe tackling this properly will require fairly extensive updating of how we manage dependencies. As such I'd prefer to keep this as a hotfix one-liner, and not add pinning to all deps listed in |
I used poetry in another project and absolutely loved it! |
I liked it (poetry) also, but got stuck on a step at the time, heres my try at it: https://github.com/apache/superset/pull/8079/files @villebro true that this is a bigger problem |
SUMMARY
Currently
pip install apache-superset
pulls in an incompatible version ofPyJWT
due to it being restricted on one of the dependencies. See https://stackoverflow.com/questions/60303682/why-is-pip-installing-an-incompatible-package-version for more info. Note: this is just a quick fix; we should preferably do some more work in this area to have more robust dependency resolution and achieving proper locking e.g. via poetry.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION