chore: add breaking change to title regex

[eschutho]

SUMMARY

Per #12566 [SIP 57] adding a regex check to allow for a title that has a breaking-change prefix. Authors should use this prefix for any fixes, features, perf, refactor, etc that is a breaking change.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-io]

Codecov Report

Merging #12754 (8afec73) into master (55c8f9b) will decrease coverage by 2.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12754      +/-   ##
==========================================
- Coverage   66.68%   64.16%   -2.52%     
==========================================
  Files        1021      488     -533     
  Lines       50008    30403   -19605     
  Branches     4905        0    -4905     
==========================================
- Hits        33346    19508   -13838     
+ Misses      16532    10895    -5637     
+ Partials      130        0     -130     

Flag	Coverage Δ
cypress	?
javascript	?
python	64.16% <ø> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engines/hive.py	0.00% <0.00%> (-85.72%)	⬇️
superset/db_engine_specs/hive.py	73.84% <0.00%> (-17.31%)	⬇️
superset/utils/cache.py	76.34% <0.00%> (-8.77%)	⬇️
superset/db_engine_specs/presto.py	88.09% <0.00%> (-0.44%)	⬇️
superset/models/core.py	88.58% <0.00%> (-0.28%)	⬇️
superset/viz.py	59.02% <0.00%> (-0.04%)	⬇️
superset/charts/schemas.py	100.00% <0.00%> (ø)
superset/common/query_context.py	82.58% <0.00%> (ø)
...ntend/src/dashboard/components/PublishedStatus.jsx
.../src/dashboard/components/menu/PopoverDropdown.jsx
... and 534 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c8f9b...8afec73. Read the comment docs.

[ktmud]

The prefixes are task types. "Breaking change" sounds more like a flag or label.

Conventional commits specifies breaking changes should add ! to task type, or include BREAKING CHANGE: in the footer. E.g.

refactor!: drop support for Python 3.6

or

refactor!: drop support for Python 3.6

BREAKING CHANGE: as discussed in #xxxx, Python 3.6 is no longer supported.

I think it'd be worthwhile following the best practices from the community.

[eschutho]

The prefixes are task types. "Breaking change" sounds more like a flag or label.

Conventional commits specifies breaking changes should add ! to task type, or include BREAKING CHANGE: in the footer. E.g.

refactor!: drop support for Python 3.6

or

refactor!: drop support for Python 3.6

BREAKING CHANGE: as discussed in #xxxx, Python 3.6 is no longer supported.

I think it'd be worthwhile following the best practices from the community.

Thanks, this is a good resource @ktmud.

[eschutho]

@nytai I escaped the parens here.. was that intentional originally? Also, do you know the reason for the last s?

[nytai]

TBH, I'm also a little confused by this regex. I lifted it from this file https://github.com/apache/superset/blob/dc893fe1b3b86e2921bb77e08a531db46b3f8e5d/.github/prlint.json
that @mistercrunch added

[nytai]

Ok, this is making more sense now. Looks like there's some yaml escaping in here too. I'm seeing there was a mistake in the original parens, so the previous regex allowed anything after the prefix and before the :, so buildskjdsfsdfsdbjfds: dsfds would have been valid 🤣. The last \s is the ensure there's white space after the :

[eschutho]

Ok, gotcha. yeah, the yaml escaping threw me off on the \\s at first too. Luckily the linter caught the new ones.

[eschutho]

rebuilding