-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Updates to Superset Site for 1.0 #12626
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12626 +/- ##
==========================================
- Coverage 66.80% 63.61% -3.20%
==========================================
Files 1017 486 -531
Lines 49730 29984 -19746
Branches 4864 0 -4864
==========================================
- Hits 33221 19073 -14148
+ Misses 16386 10911 -5475
+ Partials 123 0 -123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should undo the package-lock.json file changes
no reason you should push this right?
docs/src/pages/docs/introduction.mdx
Outdated
- Download the latest Superset version from [Pypi here](https://pypi.org/project/apache-superset/) | ||
- Setup Superset locally with one command | ||
using [Docker Compose](docs/installation/installing-superset-using-docker-compose) | ||
- Download the [Docker image](https://hub.docker.com/r/apache/incubator-superset) from Dockerhub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to point to https://hub.docker.com/r/apache/superset
now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, fixing now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like package.json wasn't changed. can you undo the change for package-lock.json?
* master: (52 commits) docs: Updates to Superset Site for 1.0 (apache#12626) test(native-filters): scoping tree in native filters modal (apache#12655) Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219) Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224) Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227) feat(native-filters): apply scoping of native filters to dashboard (apache#12716) Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223) Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245) fix: missing select menu background (apache#12759) fix(explore): incorrect missing datasource condition (apache#12758) feat: default timepicker to last week when dataset is changed (apache#12609) feat(explore): allow opening charts with missing dataset (apache#12705) chore: upgrade Cypress to 6.2.1 (apache#12605) refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218) feat: Adding option to set_database_uri CLI command (apache#12740) docs: Fixed typo on line 348 (apache#12739) Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214) docs: Remove gatsby-plugin-offline (apache#12693) test: oracle engine spec (apache#12615) test: hive db engine spec (apache#12520) ...
SUMMARY
Updated all screenshots to now showcase Superset 1.0 design.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN