Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: improve webpack configs for npm link #12313

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Jan 6, 2021

SUMMARY

I noticed that sometimes Webpack will not use the source files of @superset-ui/core when is it installed via npm link.

This change should fix it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

Test locally.

  1. npm link both the core package and a plugin package.
  2. Start npm dev-server.
  3. Go to Chrome Dev Tools "Sources" panal, use Cmd + p to search for files.
  4. You should see files from superset-ui/core/src instead of superset-ui/core/esm.

@codecov-io
Copy link

codecov-io commented Jan 6, 2021

Codecov Report

Merging #12313 (7ede370) into master (6df8224) will decrease coverage by 4.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12313      +/-   ##
==========================================
- Coverage   67.15%   62.99%   -4.16%     
==========================================
  Files        1002     1002              
  Lines       49265    49286      +21     
  Branches     5003     5010       +7     
==========================================
- Hits        33082    31049    -2033     
- Misses      16060    18035    +1975     
- Partials      123      202      +79     
Flag Coverage Δ
cypress ?
javascript 61.20% <ø> (-0.02%) ⬇️
python 64.16% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/dashboard/containers/SliceAdder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/explore/reducers/getInitialState.js 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/visualizations/presets/MainPreset.js 0.00% <0.00%> (-100.00%) ⬇️
... and 197 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df8224...7ede370. Read the comment docs.

@ktmud ktmud requested review from etr2460, nytai and villebro January 6, 2021 23:49
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!!!!

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, works perfectly now!

@ktmud ktmud merged commit bcb8db6 into apache:master Jan 7, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants