Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct null check for condition threshold to allow 0 values #12295

Merged

Conversation

riahk
Copy link
Contributor

@riahk riahk commented Jan 5, 2021

SUMMARY

  • Add an extra !== undefined check to condition threshold to allow falsey values (0) to display in edit mode

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Manual test:

  1. Create an alert with condition threshold of 0
  2. Save
  3. Edit same alert and ensure that threshold displays properly

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 6, 2021

Codecov Report

Merging #12295 (0d77b28) into master (4149ab4) will decrease coverage by 15.76%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #12295       +/-   ##
===========================================
- Coverage   67.17%   51.40%   -15.77%     
===========================================
  Files        1002      466      -536     
  Lines       49232    16760    -32472     
  Branches     5000     4303      -697     
===========================================
- Hits        33073     8616    -24457     
+ Misses      16036     8144     -7892     
+ Partials      123        0      -123     
Flag Coverage Δ
cypress 51.40% <0.00%> (-0.01%) ⬇️
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 4.41% <0.00%> (-41.99%) ⬇️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx 11.76% <0.00%> (-88.24%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
superset-frontend/src/components/IconTooltip.tsx 13.33% <0.00%> (-86.67%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...end/src/SqlLab/components/ExploreResultsButton.jsx 8.00% <0.00%> (-84.00%) ⬇️
... and 857 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4149ab4...0d77b28. Read the comment docs.

@mistercrunch mistercrunch merged commit b012768 into apache:master Jan 6, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants