Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ignore github actions from dependabot #12291

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Jan 5, 2021

SUMMARY

Ask Dependabot to ignore .github/actions since the dependencies in the local copy of external actions should be manually updated when we update the action.

Related: #12241

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

CI must pass.

@ktmud ktmud closed this Jan 5, 2021
@ktmud ktmud reopened this Jan 5, 2021
@robdiciuccio
Copy link
Member

Does this prevent Dependabot security notifications for Github Actions, or just the automated update PRs? It's not very clear from the docs.

@ktmud ktmud force-pushed the dependabot-ignore-actions branch from 060f87e to 324f5de Compare January 6, 2021 00:16
@ktmud
Copy link
Member Author

ktmud commented Jan 6, 2021

@robdiciuccio I think this does affect security notifications:

Any options that also affect security updates are used the next time a security alert triggers a pull request for a security update.

But I just found out you can choose to keep the checks but disable pull requests: https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuration-options-for-dependency-updates#open-pull-requests-limit

I've updated the PR accordingly. Thanks for pointing this out!

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktmud ktmud merged commit cf1c57a into apache:master Jan 6, 2021
@ktmud ktmud deleted the dependabot-ignore-actions branch January 6, 2021 06:46
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants