Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sql toolbar fixes round 2 #12287

Merged
merged 5 commits into from
Jan 6, 2021
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jan 5, 2021

SUMMARY

Additional changes recommended by product for sql toolbar enhancements

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #12287 (5523d05) into feat-sql-toolbar (8a288b2) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           feat-sql-toolbar   #12287      +/-   ##
====================================================
- Coverage             67.04%   67.04%   -0.01%     
====================================================
  Files                  1001     1001              
  Lines                 49268    49267       -1     
  Branches               5011     5010       -1     
====================================================
- Hits                  33034    33032       -2     
- Misses                16108    16109       +1     
  Partials                126      126              
Flag Coverage Δ
cypress 51.13% <66.66%> (+<0.01%) ⬆️
javascript 61.07% <66.66%> (-0.01%) ⬇️
python 64.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/SqlLab/components/EstimateQueryCostButton.jsx 20.83% <0.00%> (ø)
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 55.71% <ø> (ø)
...perset-frontend/src/common/components/Dropdown.tsx 57.50% <ø> (ø)
...end/src/SqlLab/components/RunQueryActionButton.tsx 67.56% <100.00%> (-0.86%) ⬇️
...rontend/src/SqlLab/components/TabbedSqlEditors.jsx 81.64% <100.00%> (ø)
...set-frontend/src/dashboard/util/getDropPosition.js 92.06% <0.00%> (-1.59%) ⬇️
...ntend/src/dashboard/components/PropertiesModal.jsx 83.03% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a288b2...5523d05. Read the comment docs.

@hughhhh hughhhh changed the title set the overflow menu 176px fix: Sql toolbar fixes round 2 Jan 5, 2021
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hughhhh hughhhh merged commit 0d76111 into feat-sql-toolbar Jan 6, 2021
@hughhhh hughhhh deleted the hugh/feat-sql-toolbar-r2 branch January 6, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants