feat: update sql toolbar styling #12164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feat-sql-toolbar #12164 +/- ##
====================================================
- Coverage 64.13% 63.27% -0.87%
====================================================
Files 484 971 +487
Lines 31888 48118 +16230
Branches 0 4794 +4794
====================================================
+ Hits 20451 30446 +9995
- Misses 11437 17479 +6042
- Partials 0 193 +193
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
changed the title
eschutho
force-pushed
the
elizabeth/sqlToolbar-styling
branch
from
f162e54 to
a36940c
Compare
eschutho
force-pushed
the
elizabeth/sqlToolbar-styling
branch
from
a36940c to
6cb010e
Compare
hughhhh
reviewed
Dec 22, 2020
| @@ -20,7 +20,7 @@ import React from 'react'; | |||
| import { styled } from '@superset-ui/core'; | |||
| // eslint-disable-next-line no-restricted-imports | |||
| import { Menu as AntdMenu, Dropdown, Skeleton } from 'antd'; | |||
| import { DropDownProps } from 'antd/lib/dropdown'; | |||
| import { DropDownProps as AnddDropdownProps } from 'antd/lib/dropdown'; | |||
There was a problem hiding this comment.
Suggested change
| import { DropDownProps as AnddDropdownProps } from 'antd/lib/dropdown'; | |
| import { DropDownProps as AntdDropdownProps } from 'antd/lib/dropdown'; |
hughhhh
reviewed
Dec 22, 2020
| <> | ||
| <i | ||
| className="fa fa-stop" | ||
| style={{ display: 'inline-block', marginRight: '10px' }} |
There was a problem hiding this comment.
can we set this as var above the build text vs inline
There was a problem hiding this comment.
ah, thanks. I meant to come back to that.
|
restarting cypress |
hughhhh
approved these changes
Dec 22, 2020
eschutho
added a commit
to preset-io/superset
that referenced
this pull request
Dec 23, 2020
* save quite * working func for ctas and cvas * fixing errors * fix type errors * fix things * fix * styling for toolbar * adjust styling Co-authored-by: hughhhh <hughmil3s@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Styling of the toolbar according to designs
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
NEW:
TEST PLAN
visual testing only (other test should still pass)
ADDITIONAL INFORMATION