Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: cancel previous github action runs #11940

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Dec 4, 2020

SUMMARY

CI has been slow recently, partly because of long running queue.

Each new commits to an open PR triggers a new CI job. Let's see if cancelling previous runs helps speed things up.

Ref: https://github.com/styfle/cancel-workflow-action

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

CI should work

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Dec 5, 2020

Codecov Report

Merging #11940 (e474f43) into master (98dc657) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11940      +/-   ##
==========================================
+ Coverage   67.63%   67.82%   +0.18%     
==========================================
  Files         932      937       +5     
  Lines       45221    45520     +299     
  Branches     4335     4341       +6     
==========================================
+ Hits        30587    30872     +285     
- Misses      14531    14545      +14     
  Partials      103      103              
Flag Coverage Δ
cypress 55.10% <ø> (+0.25%) ⬆️
javascript 62.99% <ø> (-0.15%) ⬇️
python 64.37% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/src/dashboard/components/PropertiesModal.jsx 83.03% <0.00%> (-1.79%) ⬇️
superset/config.py 89.00% <0.00%> (-1.07%) ⬇️
...end/src/SqlLab/components/TemplateParamsEditor.jsx 88.88% <0.00%> (-0.31%) ⬇️
superset-frontend/src/chart/Chart.jsx 58.18% <0.00%> (ø)
superset-frontend/src/common/components/index.tsx 100.00% <0.00%> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 73.59% <0.00%> (ø)
...erset-frontend/src/profile/components/Security.tsx 100.00% <0.00%> (ø)
...-frontend/src/common/components/common.stories.tsx 0.00% <0.00%> (ø)
superset-frontend/src/common/components/Badge.tsx 100.00% <0.00%> (ø)
superset/sql_validators/postgres.py 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98dc657...e474f43. Read the comment docs.

@ktmud ktmud closed this Dec 5, 2020
@ktmud ktmud reopened this Dec 5, 2020
@ktmud ktmud closed this Dec 5, 2020
@ktmud ktmud reopened this Dec 5, 2020
@ktmud ktmud closed this Dec 5, 2020
@ktmud ktmud reopened this Dec 5, 2020
@ktmud ktmud closed this Dec 5, 2020
@ktmud ktmud reopened this Dec 5, 2020
@ktmud ktmud closed this Dec 5, 2020
@ktmud ktmud reopened this Dec 5, 2020
@ktmud ktmud closed this Dec 5, 2020
@ktmud ktmud reopened this Dec 5, 2020
@ktmud ktmud closed this Dec 5, 2020
@ktmud ktmud reopened this Dec 5, 2020
@ktmud ktmud closed this Dec 5, 2020
@ktmud ktmud reopened this Dec 5, 2020
@ktmud ktmud closed this Dec 5, 2020
@ktmud ktmud reopened this Dec 5, 2020
@ktmud ktmud closed this Dec 5, 2020
@ktmud ktmud reopened this Dec 5, 2020
@ktmud ktmud closed this Dec 5, 2020
@ktmud ktmud reopened this Dec 5, 2020
@ktmud ktmud closed this Dec 5, 2020
@ktmud ktmud reopened this Dec 5, 2020
@ktmud ktmud closed this Dec 5, 2020
@ktmud ktmud reopened this Dec 5, 2020
@ktmud ktmud closed this Dec 5, 2020
@ktmud ktmud reopened this Dec 5, 2020
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you!

@ktmud ktmud merged commit 8164aea into apache:master Dec 8, 2020
@ktmud ktmud deleted the cancel-previous-runs branch December 8, 2020 23:27
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants