Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css templates): security perm simplification #11856

Merged

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Nov 30, 2020

SUMMARY

security permission simplification. Scope Css Templates for API and MVC FAB classes.

Existing permissions:

Permission View
can_list CssTemplateModelView
can_show CssTemplateModelView
can_edit CssTemplateModelView
can_delete CssTemplateModelView
can_add CssTemplateModelView
muldelete CssTemplateModelView
can_list CssTemplateAsyncModelView
muldelete CssTemplateAsyncModelView

Future permissions:

Permission View
can_read CssTemplate
can_write CssTemplate

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

Merging #11856 (c4d84f3) into master (a4f4425) will decrease coverage by 12.43%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #11856       +/-   ##
===========================================
- Coverage   67.59%   55.16%   -12.44%     
===========================================
  Files         917      417      -500     
  Lines       44730    14671    -30059     
  Branches     4235     3762      -473     
===========================================
- Hits        30236     8093    -22143     
+ Misses      14391     6578     -7813     
+ Partials      103        0      -103     
Flag Coverage Δ
cypress 55.16% <0.00%> (-0.06%) ⬇️
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx 1.29% <0.00%> (-75.88%) ⬇️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...ontend/src/dashboard/util/getDashboardFilterKey.ts 14.28% <0.00%> (-85.72%) ⬇️
...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx 14.70% <0.00%> (-82.97%) ⬇️
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx 5.71% <0.00%> (-82.10%) ⬇️
... and 772 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f4425...c4d84f3. Read the comment docs.

@dpgaspar dpgaspar changed the title feat: security converge css templates feat(css templates): security perm simplification Dec 1, 2020
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 1, 2020
@dpgaspar dpgaspar marked this pull request as ready for review December 1, 2020 00:38
@dpgaspar dpgaspar requested a review from willbarrett December 1, 2020 00:40
@dpgaspar dpgaspar added the risk:db-migration PRs that require a DB migration label Dec 1, 2020
Copy link
Member

@willbarrett willbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Daniel!

@dpgaspar dpgaspar merged commit 71c567b into apache:master Dec 3, 2020
@dpgaspar dpgaspar deleted the feat/security-converge-csstemplates branch December 3, 2020 08:45
graceguo-supercat pushed a commit to airbnb/superset-fork that referenced this pull request Dec 4, 2020
* feat: security converge css templates

* fix security tests

* fix JS test

* add migration

* black and fix migration

(cherry picked from commit 71c567b)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:db-migration PRs that require a DB migration size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants