Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Implement [SIP-56] Adopt React Testing Library for testing React components.
As demonstrated in the new code, with RTL, we are able to easily test the use of the
useEffect
hook with DOM updates, that is previously not possible to do in Enzyme. Just make sure to use waitFor to wait for the DOM change, otherwise you may encounteran update inside a test was not wrapped in act(...)
errors.Another lesson learned is that in order to use
waitFor
, you must explicitly add ajest-environment: jsdom
docblock to the test file, because the default jest environmentjest-enzyme
is incompatible with RTL.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
CI
ADDITIONAL INFORMATION