feat(saved queries): security perm simplification #11764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11764 +/- ##
===========================================
- Coverage 67.56% 55.08% -12.49%
===========================================
Files 916 411 -505
Lines 44545 14583 -29962
Branches 4227 3749 -478
===========================================
- Hits 30098 8033 -22065
+ Misses 14344 6550 -7794
+ Partials 103 0 -103
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dpgaspar
changed the title
dpgaspar
changed the title
|
@dpgaspar I gather that other than one test file and one implementation place, there were no front-end changes required to support this? |
willbarrett
reviewed
Nov 24, 2020
| Base = declarative_base() | ||
|
|
||
| PvmType = Tuple[str, str] | ||
| PvmMigrationMapType = Dict[PvmType, Tuple[PvmType, ...]] |
There was a problem hiding this comment.
Why the tuple? Will these ever be anything other than 1:1?
There was a problem hiding this comment.
They will, on downgrade we need 1:N because I'm "recovering" for example: "can_read" -> ("can_show", "can_list", ...)
dpgaspar
commented
Nov 24, 2020
villebro
approved these changes
Nov 27, 2020
Comment on lines
+68
to
+98
| MODEL_VIEW_RW_METHOD_PERMISSION_MAP = { | ||
| "add": "write", | ||
| "api": "read", | ||
| "api_column_add": "write", | ||
| "api_column_edit": "write", | ||
| "api_create": "write", | ||
| "api_delete": "write", | ||
| "api_get": "read", | ||
| "api_read": "read", | ||
| "api_readvalues": "read", | ||
| "api_update": "write", | ||
| "delete": "write", | ||
| "download": "read", | ||
| "edit": "write", | ||
| "list": "read", | ||
| "muldelete": "write", | ||
| "show": "read", | ||
| } | ||
|
|
||
| MODEL_API_RW_METHOD_PERMISSION_MAP = { | ||
| "bulk_delete": "write", | ||
| "delete": "write", | ||
| "distinct": "read", | ||
| "export": "read", | ||
| "get": "read", | ||
| "get_list": "read", | ||
| "info": "read", | ||
| "post": "write", | ||
| "put": "write", | ||
| "related": "read", | ||
| } |
There was a problem hiding this comment.
Could we add Enums for these, like PermissionType.WRITE?
dpgaspar
commented
Nov 27, 2020
dpgaspar
commented
Nov 27, 2020
willbarrett
approved these changes
Nov 27, 2020
6 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
First PR for security permission simplification. Scope
SavedQueryfor API and MVC FAB classes.The DB migration step is ready to upgrade and downgrade, note that downgrade will work just fine with superset default roles, but on custom made roles some granularity may be lost, since after converging (upgrading) there is information loss
Existing permissions:
Future permissions:
TEST PLAN
Test REACT CRUD views
Test MVC CRUD views
ADDITIONAL INFORMATION