Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix docker config paths #11703

Merged
merged 2 commits into from
Nov 18, 2020
Merged

docs: fix docker config paths #11703

merged 2 commits into from
Nov 18, 2020

Conversation

suddjian
Copy link
Member

@suddjian suddjian commented Nov 14, 2020

SUMMARY

Just pointin' people in the right direction

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@etr2460 etr2460 changed the title docs: fix doker config paths docs: fix docker config paths Nov 14, 2020
@suddjian
Copy link
Member Author

this is a docs change and e2e has failed 3 times :(

@mistercrunch
Copy link
Member

xit!

@codecov-io
Copy link

codecov-io commented Nov 18, 2020

Codecov Report

Merging #11703 (942b6f6) into master (68693c7) will increase coverage by 4.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11703      +/-   ##
==========================================
+ Coverage   62.86%   67.27%   +4.41%     
==========================================
  Files         889      897       +8     
  Lines       43055    46427    +3372     
  Branches     4017     4088      +71     
==========================================
+ Hits        27065    31233    +4168     
+ Misses      15811    15084     -727     
+ Partials      179      110      -69     
Flag Coverage Δ
cypress 55.21% <ø> (?)
javascript 62.89% <ø> (+0.07%) ⬆️
python 63.72% <ø> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/cache.py 63.29% <0.00%> (-16.71%) ⬇️
...et-frontend/src/SqlLab/components/LimitControl.tsx 89.36% <0.00%> (-1.95%) ⬇️
...ntend/src/views/CRUD/annotation/AnnotationList.tsx 77.17% <0.00%> (-0.85%) ⬇️
...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx 73.03% <0.00%> (-0.83%) ⬇️
superset/__init__.py 100.00% <0.00%> (ø)
superset/constants.py 100.00% <0.00%> (ø)
superset/viz_sip38.py 0.00% <0.00%> (ø)
superset/databases/schemas.py 100.00% <0.00%> (ø)
superset/utils/cache_manager.py 100.00% <0.00%> (ø)
superset-frontend/src/common/components/index.tsx 100.00% <0.00%> (ø)
... and 213 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68693c7...942b6f6. Read the comment docs.

@suddjian suddjian merged commit 676e0bb into master Nov 18, 2020
@suddjian suddjian deleted the docs-docker-config-path branch November 18, 2020 06:00
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* docs: fix config paths for docker

* xit bad cypress tests
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants