fix: revert eTag cache feature for dashboard

[graceguo-supercat]

SUMMARY

After enable eTag header for dashboard request (in airbnb), we found the cached content has user_id and dashboard edit permission, etc, user-specific data, is shared by all the users.

Need to revert this feature (with 2 PRs) by now. Possible fix could be separate dashboard bootstrap data in the future.

TEST PLAN

CI

ADDITIONAL INFORMATION

• Has associated issue: fix: enable consistent etag across workers and force no-cache for dashboards #11137 feat: enable ETag header for dashboard GET requests #10963

cc @ktmud @etr2460 @john-bodley

[codecov-io]

Codecov Report

Merging #11203 into master will increase coverage by 0.02%.
The diff coverage is 73.07%.

@@            Coverage Diff             @@
##           master   #11203      +/-   ##
==========================================
+ Coverage   65.60%   65.62%   +0.02%     
==========================================
  Files         828      828              
  Lines       39167    39148      -19     
  Branches     3589     3589              
==========================================
- Hits        25694    25690       -4     
+ Misses      13361    13347      -14     
+ Partials      112      111       -1     

Flag	Coverage Δ
#cypress	55.87% <ø> (+0.42%)	⬆️
#javascript	62.30% <ø> (ø)
#python	61.01% <73.07%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/config.py	90.07% <ø> (ø)
superset/utils/decorators.py	55.00% <60.00%> (+4.23%)	⬆️
superset/views/core.py	74.20% <72.22%> (-0.06%)	⬇️
superset/views/utils.py	82.68% <100.00%> (+<0.01%)	⬆️
...rontend/src/visualizations/FilterBox/FilterBox.jsx	56.17% <0.00%> (-9.88%)	⬇️
.../src/dashboard/components/gridComponents/Chart.jsx	83.67% <0.00%> (-2.05%)	⬇️
...t-frontend/src/dashboard/actions/dashboardState.js	50.32% <0.00%> (-1.31%)	⬇️
superset/models/dashboard.py	88.03% <0.00%> (-0.43%)	⬇️
...set/superset-frontend/src/SqlLab/actions/sqlLab.js	60.68% <0.00%> (+0.42%)	⬆️
...erset-frontend/src/components/DatabaseSelector.tsx	91.30% <0.00%> (+1.08%)	⬆️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6728d8...f98e4f9. Read the comment docs.

[etr2460]

thanks for the revert! there's probably a way to surgically pull out some of @ktmud's change and leave it in, but it might be safer to just do the full revert here.

[ktmud]

The changes should be safe to most Superset deployments because one needs to manually turn on the ENABLE_DASHBOARD_ETAG_HEADER feature for the code change to apply. But reverting is probably warranted since it's kind of expensive to have different ETag caches per user so maybe we can explore other paths to make the caching better for the dashboard page.

[graceguo-supercat]

if you feel partial code is useful for something else, i suggest you create a new PR for the specific purpose.