Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: breaking docs CI #11156

Closed

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Oct 4, 2020

SUMMARY

The CI checks are failing in master for changes which relate to the documentation. This PR fixes the lint issues.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

Codecov Report

Merging #11156 into master will decrease coverage by 3.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11156      +/-   ##
==========================================
- Coverage   65.84%   62.21%   -3.64%     
==========================================
  Files         827      436     -391     
  Lines       39051    14560   -24491     
  Branches     3673     3673              
==========================================
- Hits        25715     9059   -16656     
+ Misses      13229     5320    -7909     
- Partials      107      181      +74     
Flag Coverage Δ
#cypress ?
#javascript 62.21% <ø> (ø)
#python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupFormatters.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupPluginsExtra.js 0.00% <0.00%> (-100.00%) ⬇️
... and 554 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d76f81...602fede. Read the comment docs.

@john-bodley john-bodley force-pushed the john-bodley--fix-breaking-ci branch from a0a6ff6 to 0b60b54 Compare October 4, 2020 22:18
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Oct 4, 2020
@john-bodley john-bodley force-pushed the john-bodley--fix-breaking-ci branch from 0b60b54 to 9c2f44a Compare October 4, 2020 22:18
@pull-request-size pull-request-size bot added size/XS and removed size/M labels Oct 4, 2020
@john-bodley
Copy link
Member Author

Actually there seems to be another issue related to gatsbyjs/gatsby#26941. @rusackas et al. would you be able to look into this?

@mistercrunch
Copy link
Member

Yeah that one drove me crazy. gatsby-plugin-mdx doesn't like the ASF header/comment on docs/README.md, and RAT (ASF-license scanner/validator) doesn't want to ignore that file (looks like a bug where it doesn't want to .rat-exclude a README file). After going down the rabbit hole unsuccessfully I decided that the easy hack forward is to rename README.md to README.txt.

I'm having other issues with Fossa going MiA my PR that does that (amongst other things)
#11154

@mistercrunch
Copy link
Member

I managed to merge my PR that addresses the issues mentioned here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants