Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup FAB update perms #11155

Merged

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Oct 4, 2020

SUMMARY

Superset has now configured FAB correctly in terms of when permissions should be updated, i.e., by default they shouldn't (per here) and only updated when running superset init (per here) and thus it seems the documentation regarding FAB_UPDATE_PERMS is obsolete (it was originally added for a use case prior to FAB 2.0).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley force-pushed the john-bodley--cleanup-FAB_UPDATE_PERMS branch from 3172ff8 to 7dd3679 Compare October 4, 2020 15:57
@john-bodley john-bodley changed the title John bodley cleanup fab update perms chore: cleanup fab update perms Oct 4, 2020
@john-bodley john-bodley marked this pull request as ready for review October 4, 2020 16:11
@john-bodley john-bodley force-pushed the john-bodley--cleanup-FAB_UPDATE_PERMS branch from 7dd3679 to 8b91b26 Compare October 4, 2020 16:12
@@ -552,7 +552,6 @@ def configure_fab(self) -> None:
appbuilder.indexview = SupersetIndexView
appbuilder.base_template = "superset/base.html"
appbuilder.security_manager_class = custom_sm
appbuilder.update_perms = False
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already False per here which is set by FAB either here and potentially reset here, though isn't since self.update_perms is already False.

@john-bodley john-bodley changed the title chore: cleanup fab update perms chore: cleanup FAB update perms Oct 4, 2020
@john-bodley john-bodley force-pushed the john-bodley--cleanup-FAB_UPDATE_PERMS branch from 8b91b26 to 6051fd8 Compare October 5, 2020 18:17
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, using just FAB_UPDATE_PERMS config key is more flexible, but we assume no one wants to run superset that way

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for keeping the codebase/docs clean! 🧹 ❤️

@john-bodley john-bodley merged commit 6e0d1b8 into apache:master Oct 7, 2020
@john-bodley john-bodley deleted the john-bodley--cleanup-FAB_UPDATE_PERMS branch October 7, 2020 15:33
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* chore: Using cache factory method

* chore: Deprecate outdated FAB_UPDATE_PERMS information

Co-authored-by: John Bodley <john.bodley@airbnb.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants