Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alembic migration error msg trying to delete constraint on tables #11115

Merged
merged 4 commits into from
Oct 1, 2020
Merged

fix: alembic migration error msg trying to delete constraint on tables #11115

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a359b0
fix: alembic migration fails by deleting non existent constraint on t…
dpgaspar Sep 30, 2020
4219f83
Revert "fix: alembic migration fails by deleting non existent constra…
dpgaspar Sep 30, 2020
ef93f98
mantain migration but just for MySQL and add downgrade procedure
dpgaspar Sep 30, 2020
35c93bc
skip the downgrade
dpgaspar Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions superset/migrations/versions/18532d70ab98_fix_table_unique_constraint_in_mysql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,20 @@
down_revision = "3fbbc6e8d654"

from alembic import op
from sqlalchemy.dialects.mysql.base import MySQLDialect


def upgrade():
try:
bind = op.get_bind()
if isinstance(bind.dialect, MySQLDialect):
# index only exists in mysql db
with op.get_context().autocommit_block():
op.drop_constraint("table_name", "tables", type_="unique")
except Exception as ex:
print(ex)


def downgrade():
pass
bind = op.get_bind()
if isinstance(bind.dialect, MySQLDialect):
# index only exists in mysql db
with op.get_context().autocommit_block():
op.add_constraint("table_name", "tables", type_="unique")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AttributeError: module 'alembic.op' has no attribute 'add_constraint'

I would say - let's pass on the downgrade. That constraint was never needed