Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add created by chart CRUD view #11067

Merged
merged 5 commits into from
Sep 30, 2020

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Sep 25, 2020

SUMMARY

  • add created_by to chart CRUD view

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2020-09-25 at 4 23 49 PM
Screen Shot 2020-09-25 at 4 26 22 PM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang marked this pull request as draft September 25, 2020 17:17
@lilykuang lilykuang force-pushed the lily/add-created-by-chart-list branch 2 times, most recently from 77fbac6 to d824eca Compare September 25, 2020 17:42
@codecov-commenter
Copy link

Codecov Report

Merging #11067 into master will decrease coverage by 4.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11067      +/-   ##
==========================================
- Coverage   65.79%   61.77%   -4.02%     
==========================================
  Files         816      433     -383     
  Lines       38422    14235   -24187     
  Branches     3621     3622       +1     
==========================================
- Hits        25280     8794   -16486     
+ Misses      13034     5255    -7779     
- Partials      108      186      +78     
Flag Coverage Δ
#cypress ?
#javascript 61.77% <100.00%> (+<0.01%) ⬆️
#python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 72.26% <100.00%> (-10.64%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupFormatters.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
... and 548 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d056e3d...d824eca. Read the comment docs.

@lilykuang lilykuang force-pushed the lily/add-created-by-chart-list branch 4 times, most recently from 9b9bcff to 2d707fe Compare September 25, 2020 23:03
@lilykuang lilykuang changed the title feat: add created by chart CRUD list feat: add created by chart CRUD view Sep 25, 2020
@lilykuang lilykuang marked this pull request as ready for review September 25, 2020 23:27
@lilykuang lilykuang force-pushed the lily/add-created-by-chart-list branch 2 times, most recently from a220a55 to 918600f Compare September 28, 2020 17:58
@lilykuang lilykuang force-pushed the lily/add-created-by-chart-list branch from 918600f to 12069a7 Compare September 29, 2020 16:27
@lilykuang lilykuang force-pushed the lily/add-created-by-chart-list branch from 12069a7 to 0f27cab Compare September 30, 2020 17:07
@nytai nytai merged commit 5b284e6 into apache:master Sep 30, 2020
@nytai nytai deleted the lily/add-created-by-chart-list branch September 30, 2020 20:54
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@benceorlai
Copy link

Roadmap: apache-superset/superset-roadmap#47

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants