refactor: Remove usages of reactable from TimeTable #11046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabryje
force-pushed
the
reactable/timetable
branch
from
aa68a05 to
ea8463a
Compare
kgabryje
changed the title
|
From the screenshot, wondering why the sparkline isn't expanding to 100% width (?) |
rusackas
reviewed
Sep 28, 2020
There was a problem hiding this comment.
Code LGTM, but I'd like to get 👀 from @nytai on the ListView tweaks and implementation.
In regard to @mistercrunch's concern, the code looks basically the same, i.e. the sparkline has
width={parseInt(column.width, 10) || 300}. @kgabryje can we repro whether or not the code on `master has the same layout with these chart columns?
|
@mistercrunch Thanks for pointing that out! A style prop for spark column wasn't passed correctly which caused it to have larger width than it should have. Fixed now. I updated the PR summary with the new screenshot. @rusackas It was my mistake, now the spark column has correct width. |
rusackas
approved these changes
Sep 28, 2020
michellethomas
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Oct 2, 2020
3 tasks
etr2460
pushed a commit
that referenced
this pull request
Oct 3, 2020
6 tasks
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* Use ListView instead of reactable * Refactor TimeTable * Spark column width fix
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
…1046)" (apache#11150) This reverts commit f01b8a3.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The goal is to replace all uses of
reactable-arclibrary with DataTable from superset-ui (which usesreact-tableunder the hood) and keep the UI/UX mostly unchanged. The reason for that is thatreactable-archas been unsupported for 2 years now, uses deprecated lifecycle methods and is incompatible with Typescript.This PR replaces
reactable-arcinTimeTablecomponent.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION