Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-integer timezone Offset in the UI. #296

Closed
manurana opened this issue Apr 8, 2016 · 10 comments
Closed

Support for non-integer timezone Offset in the UI. #296

manurana opened this issue Apr 8, 2016 · 10 comments
Labels
enhancement:request Enhancement request submitted by anyone from the community inactive Inactive for >= 30 days

Comments

@manurana
Copy link

manurana commented Apr 8, 2016

In the table details, there is a field called Offset. Currently, you cannot set a non-integer value for this. India (IST) has a 5hr 30 min offset. Need a way to configure this in the field.

@sid88in
Copy link
Contributor

sid88in commented Apr 9, 2016

@manurana looks like you are requesting similar feature to this : #299 ?
I am planning to add timezone filter in the UI to convert data between timezones.

@manurana
Copy link
Author

@sid88in : these settings can be at a system level, source level, table level, or UI level (report)
The current implementation is at a table level. System level would be the best. An override at a report level would be a nice to have.

@sid88in
Copy link
Contributor

sid88in commented Apr 10, 2016

@manurana for my use case it makes more sense to have a timezone parameter (UTC, EST, PST, IST..etc) on the UI so that multiple users can see the results as they want.

@sid88in
Copy link
Contributor

sid88in commented Apr 10, 2016

We can certainly discuss the pros/cons of having such parameter at system level, source level, table level, or UI level (report).

@manurana
Copy link
Author

In most cases, the user does not need to go into the details of the TZ. The admin sets this once (at a system level) and thats it. You might have a specific use case where the user needs to change this often during the course of his work, but its not common.

@sid88in
Copy link
Contributor

sid88in commented Apr 11, 2016

agree - depends on the use case ;)

@xrmx xrmx added the enhancement:request Enhancement request submitted by anyone from the community label Aug 9, 2016
@liuluxyz
Copy link

@sid88in Hi, you mentioned that you plan to add timezone filter. May I know what is the progress?

@mistercrunch
Copy link
Member

It would make sense to have a timezone feature in the time-related section of the explore view.

@kristw kristw added the inactive Inactive for >= 30 days label Mar 20, 2019
@stale stale bot closed this as completed Apr 11, 2019
@anilvpatel21
Copy link

@mistercrunch Any update on this? Hour Offset still supports integer value. Using 0.38.0 version of superset.

@varunvora
Copy link

Waiting for this feature. Would prefer IANA timezone support..

graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this issue Oct 4, 2021
Bumps [@vx/responsive](https://github.com/hshoff/vx) from 0.0.193 to 0.0.194.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.193...v0.0.194)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
Bumps [@vx/responsive](https://github.com/hshoff/vx) from 0.0.193 to 0.0.194.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.193...v0.0.194)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
Bumps [@vx/responsive](https://github.com/hshoff/vx) from 0.0.193 to 0.0.194.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.193...v0.0.194)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
Bumps [@vx/responsive](https://github.com/hshoff/vx) from 0.0.193 to 0.0.194.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.193...v0.0.194)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
Bumps [@vx/responsive](https://github.com/hshoff/vx) from 0.0.193 to 0.0.194.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.193...v0.0.194)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:request Enhancement request submitted by anyone from the community inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

8 participants