Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chart]multiple charts broken on maximizing #13600

Closed
vivekdixit2510 opened this issue Mar 12, 2021 · 6 comments
Closed

[chart]multiple charts broken on maximizing #13600

vivekdixit2510 opened this issue Mar 12, 2021 · 6 comments
Labels
dashboard Namespace | Anything related to the Dashboard good first issue Good first issues for new contributors

Comments

@vivekdixit2510
Copy link

vivekdixit2510 commented Mar 12, 2021 •
edited
Loading

Screenshot

Without Maximize
max1
With Maximize
max2

Without Maximize (bar graph)

max3

With Maximize (scroll till bottom)
max4

[drag & drop image(s) here!]

Description

Pie Charts and Bar Graphs have broken on maximizing.

Design input

Pie Chart: It should not disappear from the screen.
Bar Graph: It should fit on the page.
@slayerjain
@vivekdixit2510
Copy link
Author

vivekdixit2510 commented Mar 12, 2021 •
edited
Loading

Alternative, Is there a way to disable the maximize option in superset?

@junlincc
Copy link
Member

thanks for reporting! this is a known issue. if you already have a solution to fix either or both charts, we will make sure your PR is reviewed. 🙏 @vivekdixit2510

@junlincc junlincc added dashboard Namespace | Anything related to the Dashboard good first issue Good first issues for new contributors bash! labels Mar 14, 2021
@slayerjain
Copy link

@junlincc is it possible to disable the maximise button in dashboards for the time being?

@junlincc
Copy link
Member

i dont think so, unfortunately. @slayerjain 🙏

@junlincc
Copy link
Member

junlincc commented Mar 31, 2021 •
edited
Loading

world-map is also broken

related #13297

@junlincc junlincc changed the title Pie Charts and Bar Graphs broken on maximizing [chart]multiple charts broken on maximizing Mar 31, 2021
@junlincc junlincc mentioned this issue Mar 31, 2021
Closed
2 tasks
toop added a commit to toop/superset that referenced this issue Apr 6, 2021
@toop
fixed FullSize charts broken apache#13600
c79cd36
toop added a commit to toop/superset that referenced this issue Apr 7, 2021
@toop
fixed FullSize charts broken apache#13600
eb9af28
@toop toop mentioned this issue Apr 7, 2021
Closed
8 tasks
amitmiran137 pushed a commit that referenced this issue May 2, 2021
@simcha90 @toop
test(maximize-chart): Add tests to maximize chart action (#14371)
1f8de1d 
* fixed FullSize charts broken #13600

* Update ChartHolder.jsx

* fix:fix get permission function

* test: adding tests to full screen

* lint: fix lint

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

Co-authored-by: toop <mytoop@163.com>
amitmiran137 pushed a commit that referenced this issue May 4, 2021
@simcha90
test(maximize-chart): Add tests to maximize chart action (#14371)
a9b83d3 
* fixed FullSize charts broken #13600

* Update ChartHolder.jsx

* fix:fix get permission function

* test: adding tests to full screen

* lint: fix lint

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

Co-authored-by: toop <mytoop@163.com>
(cherry picked from commit 1f8de1d)
hughhhh pushed a commit that referenced this issue May 4, 2021
@simcha90 @toop @hughhhh
test(maximize-chart): Add tests to maximize chart action (#14371)
839f279 
* fixed FullSize charts broken #13600

* Update ChartHolder.jsx

* fix:fix get permission function

* test: adding tests to full screen

* lint: fix lint

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

Co-authored-by: toop <mytoop@163.com>
@amitmiran137
Copy link
Member

Resolved #14371

Closed
3 tasks
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this issue Sep 8, 2021
@simcha90 @cccs-RyanS
test(maximize-chart): Add tests to maximize chart action (apache#14371)
0513bc7 
* fixed FullSize charts broken apache#13600

* Update ChartHolder.jsx

* fix:fix get permission function

* test: adding tests to full screen

* lint: fix lint

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

Co-authored-by: toop <mytoop@163.com>
(cherry picked from commit 1f8de1d)
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this issue Dec 17, 2021
@simcha90 @toop
test(maximize-chart): Add tests to maximize chart action (apache#14371)
63f4cd2 
* fixed FullSize charts broken apache#13600

* Update ChartHolder.jsx

* fix:fix get permission function

* test: adding tests to full screen

* lint: fix lint

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

Co-authored-by: toop <mytoop@163.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this issue Dec 29, 2021
@simcha90 @toop
test(maximize-chart): Add tests to maximize chart action (apache#14371)
d99df40 
* fixed FullSize charts broken apache#13600

* Update ChartHolder.jsx

* fix:fix get permission function

* test: adding tests to full screen

* lint: fix lint

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

Co-authored-by: toop <mytoop@163.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this issue Mar 6, 2024
@simcha90 @toop
test(maximize-chart): Add tests to maximize chart action (apache#14371)
84cfd06 
* fixed FullSize charts broken apache#13600

* Update ChartHolder.jsx

* fix:fix get permission function

* test: adding tests to full screen

* lint: fix lint

* fix: fix CR notes

* fix: fix CR notes

* fix: fix CR notes

Co-authored-by: toop <mytoop@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dashboard Namespace | Anything related to the Dashboard good first issue Good first issues for new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@slayerjain @amitmiran137 @junlincc @vivekdixit2510