[Build] moves prettier check to separate script (#9591)

* [Build] moves prettier check to separate script * rename step: eslint -> lint
apache · Apr 20, 2020 · cb51d78 · cb51d78
1 parent 237ac59
commit cb51d78
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/superset-frontend.yml b/.github/workflows/superset-frontend.yml
@@ -13,10 +13,11 @@ jobs:
       uses: apache-superset/cached-dependencies@adc6f73
       with:
         run: npm-install
-    - name: eslint
+    - name: lint
       working-directory: ./superset-frontend
       run: |
         npm run lint
+        npm run prettier-check
     - name: unit tests
       working-directory: ./superset-frontend
       run: |

diff --git a/superset-frontend/package.json b/superset-frontend/package.json
@@ -17,7 +17,8 @@
     "build-dev": "cross-env NODE_OPTIONS=--max_old_space_size=8192 NODE_ENV=development webpack --mode=development --colors --progress",
     "build-instrumented": "cross-env NODE_ENV=development BABEL_ENV=instrumented webpack --mode=development --colors --progress",
     "build": "cross-env NODE_OPTIONS=--max_old_space_size=8192 NODE_ENV=production webpack --mode=production --colors --progress",
-    "lint": "prettier --check '{src,stylesheets}/**/*.{css,less,sass,scss}' && eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx .",
+    "lint": "eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx .",
+    "prettier-check": "prettier --check '{src,stylesheets}/**/*.{css,less,sass,scss}'",
     "lint-fix": "eslint --fix --ignore-path=.eslintignore --ext .js,.jsx,.ts,tsx . && npm run clean-css",
     "clean-css": "prettier --write '{src,stylesheets}/**/*.{css,less,sass,scss}'"
   },