Skip to content

Commit

Permalink
A few cosmetic fixes (nvd3 tooltips, buttons, tables)
Browse files Browse the repository at this point in the history
  • Loading branch information
@mistercrunch
mistercrunch committed Feb 24, 2016
1 parent d582efe commit 9552d09
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 6 deletions.
6 changes: 3 additions & 3 deletions panoramix/assets/html/explore.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</div>
{% endmacro %}

<div class="datasource">
<div class="datasource container-fluid">
<form id="query" method="GET" style="display: none;">
<div class="header">
<span class="btn btn-default notbtn">
Expand All @@ -45,10 +45,10 @@
{% endif %}
<div class="btn-group results pull-right" role="group">
<a role="button" tabindex="0" class="btn btn-default" id="shortner" title="Short URL" data-toggle="popover" data-trigger="focus">
<i class="fa fa-link"></i>
<i class="fa fa-link"></i>&nbsp;
</a>
<span class="btn btn-default" id="standalone" title="Standalone version, use to embed anywhere" data-toggle="tooltip">
<i class="fa fa-code"></i>
<i class="fa fa-code"></i>&nbsp;
</span>
<span class="btn btn-default " id="json" title="Export to .json" data-toggle="tooltip">
<i class="fa fa-file-code-o"></i>
Expand Down
2 changes: 1 addition & 1 deletion panoramix/assets/stylesheets/panoramix.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ legend.legend-style {
font-weight: bold;
}
.nvtooltip {
position: relative !important;
//position: relative !important;
z-index: 888;
}

Expand Down
8 changes: 6 additions & 2 deletions panoramix/assets/visualizations/pivot_table.css
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
.gridster li.widget.pivot_table,

This comment has been minimized.

Sign in to view

Copy link
@williaster

williaster Feb 24, 2016

Contributor

for a rule that applies to multiple selections, the preferred style is to give each it's own line. we can do a more cohesive linting later.

https://github.com/airbnb/css#formatting
div.widget.pivot_table{
.gridster li.widget.pivot_table, div.widget.pivot_table {
overflow: auto !important;
}

.widget.table td {
padding: 5px 1px;
font-size: small;
}
5 changes: 5 additions & 0 deletions panoramix/assets/visualizations/table.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,8 @@ div.widget.table {
background-color: #005a63;
color: white;
}

.widget.table td {
padding: 5px 1px;
font-size: small;
}

1 comment on commit 9552d09

@williaster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the (minor) exception of the css rule, lgtm. there are enough other violations of that rule for now that I don't think it's worth fixing here.

Please sign in to comment.