fix test

apache · May 3, 2023 · 5543be7 · 5543be7
1 parent 2f67f48
commit 5543be7
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 3 deletions.
diff --git a/tests/integration_tests/explore/permalink/api_tests.py b/tests/integration_tests/explore/permalink/api_tests.py
@@ -15,7 +15,6 @@
 # specific language governing permissions and limitations
 # under the License.
 import json
-import pickle
 from typing import Any, Dict, Iterator
 from uuid import uuid3
 
@@ -24,7 +23,7 @@
 
 from superset import db
 from superset.key_value.models import KeyValueEntry
-from superset.key_value.types import KeyValueResource
+from superset.key_value.types import JsonKeyValueCodec, KeyValueResource
 from superset.key_value.utils import decode_permalink_id, encode_permalink_key
 from superset.models.slice import Slice
 from superset.utils.core import DatasourceType
@@ -95,7 +94,7 @@ def test_get_missing_chart(
     chart_id = 1234
     entry = KeyValueEntry(
         resource=KeyValueResource.EXPLORE_PERMALINK,
-        value=pickle.dumps(
+        value=JsonKeyValueCodec().encode(
             {
                 "chartId": chart_id,
                 "datasourceId": chart.datasource.id,

diff --git a/tests/integration_tests/key_value/commands/create_test.py b/tests/integration_tests/key_value/commands/create_test.py
@@ -27,6 +27,7 @@
 from superset.key_value.exceptions import KeyValueCreateFailedError
 from superset.utils.core import override_user
 from tests.integration_tests.key_value.commands.fixtures import (
+    admin,
     JSON_CODEC,
     JSON_VALUE,
     PICKLE_CODEC,

diff --git a/tests/integration_tests/key_value/commands/get_test.py b/tests/integration_tests/key_value/commands/get_test.py
@@ -28,6 +28,7 @@
     ID_KEY,
     JSON_CODEC,
     JSON_VALUE,
+    key_value_entry,
     RESOURCE,
     UUID_KEY,
 )

diff --git a/tests/integration_tests/key_value/commands/update_test.py b/tests/integration_tests/key_value/commands/update_test.py
@@ -25,8 +25,10 @@
 from superset.extensions import db
 from superset.utils.core import override_user
 from tests.integration_tests.key_value.commands.fixtures import (
+    admin,
     ID_KEY,
     JSON_CODEC,
+    key_value_entry,
     RESOURCE,
     UUID_KEY,
 )

diff --git a/tests/integration_tests/key_value/commands/upsert_test.py b/tests/integration_tests/key_value/commands/upsert_test.py
@@ -25,8 +25,10 @@
 from superset.extensions import db
 from superset.utils.core import override_user
 from tests.integration_tests.key_value.commands.fixtures import (
+    admin,
     ID_KEY,
     JSON_CODEC,
+    key_value_entry,
     RESOURCE,
     UUID_KEY,
 )