Skip to content

Commit

Permalink
allow for multiple columns in NOT GROUP BY (#560)
Browse files Browse the repository at this point in the history
  • Loading branch information
georgeke authored and mistercrunch committed Jun 3, 2016
1 parent b5fe9db commit 52c2b23
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion caravel/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,7 @@ def save_or_overwrite_slice(self, args, slc, slice_add_perm, slice_edit_perm):
d = args.to_dict(flat=False)
del d['action']
del d['previous_viz_type']
as_list = ('metrics', 'groupby', 'columns')
as_list = ('metrics', 'groupby', 'columns', 'all_columns')
for k in d:
v = d.get(k)
if k in as_list and not isinstance(v, list):
Expand Down

0 comments on commit 52c2b23

Please sign in to comment.