address review comments

apache · Jan 18, 2023 · 474e2f0 · 474e2f0
1 parent 3ec3618
commit 474e2f0
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/helm/superset/templates/service.yaml b/helm/superset/templates/service.yaml
@@ -35,7 +35,7 @@ spec:
       targetPort: http
       protocol: TCP
       name: http
-      {{- if and (or (eq .Values.service.type "NodePort") (eq .Values.service.type "LoadBalancer")) (not (nil .Values.service.nodePort.http)) }}
+      {{- if and (or (eq .Values.service.type "NodePort") (eq .Values.service.type "LoadBalancer")) (not (empty .Values.service.nodePort.http)) }}
       nodePort: {{ .Values.service.nodePort.http }}
       {{- end }}
   selector:
@@ -67,7 +67,7 @@ spec:
       targetPort: flower
       protocol: TCP
       name: flower
-      {{- if and (or (eq .Values.supersetCeleryFlower.service.type "NodePort") (eq .Values.supersetCeleryFlower.service.type "LoadBalancer")) (not (nil .Values.supersetCeleryFlower.service.nodePort.http)) }}
+      {{- if and (or (eq .Values.supersetCeleryFlower.service.type "NodePort") (eq .Values.supersetCeleryFlower.service.type "LoadBalancer")) (not (empty .Values.supersetCeleryFlower.service.nodePort.http)) }}
       nodePort: {{ .Values.supersetCeleryFlower.service.nodePort.http }}
       {{- end }}
   selector:
@@ -100,7 +100,7 @@ spec:
       targetPort: ws
       protocol: TCP
       name: ws
-      {{- if and (or (eq .Values.supersetWebsockets.service.type "NodePort") (eq .Values.supersetWebsockets.service.type "LoadBalancer")) (not (nil .Values.supersetWebsockets.service.nodePort.http)) }}
+      {{- if and (or (eq .Values.supersetWebsockets.service.type "NodePort") (eq .Values.supersetWebsockets.service.type "LoadBalancer")) (not (empty .Values.supersetWebsockets.service.nodePort.http)) }}
       nodePort: {{ .Values.supersetWebsockets.service.nodePort.http }}
       {{- end }}
   selector: