Skip to content

Commit

Permalink
fix(sqla): allow series limit without subquery support (#16896)
Browse files Browse the repository at this point in the history
  • Loading branch information
villebro committed Sep 29, 2021
1 parent 3f784cc commit 3272d1c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions superset/connectors/sqla/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -1292,8 +1292,8 @@ def get_sqla_query( # pylint: disable=too-many-arguments,too-many-locals,too-ma
if row_offset:
qry = qry.offset(row_offset)

if db_engine_spec.allows_subqueries and series_limit and groupby_series_columns:
if db_engine_spec.allows_joins:
if series_limit and groupby_series_columns:
if db_engine_spec.allows_joins and db_engine_spec.allows_subqueries:
# some sql dialects require for order by expressions
# to also be in the select clause -- others, e.g. vertica,
# require a unique inner alias
Expand Down

0 comments on commit 3272d1c

Please sign in to comment.