Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1040] rework schema definitions in geo processors #1268

Merged
merged 4 commits into from
Feb 18, 2023
Merged

[#1040] rework schema definitions in geo processors #1268

merged 4 commits into from
Feb 18, 2023

Conversation

flomickl
Copy link
Contributor

@flomickl flomickl commented Feb 11, 2023 •
edited by bossenti
Loading

Purpose

#1040 improve naming of runtime names and add missing epsg field in trajectory

Remarks

PR introduces (a) breaking change(s): yes
tested with all changes according to
https://cwiki.apache.org/confluence/x/QZBbDg
https://cwiki.apache.org/confluence/x/RpBbDg
https://cwiki.apache.org/confluence/x/SZBbDg
https://cwiki.apache.org/confluence/x/U5BbDg
https://cwiki.apache.org/confluence/x/XJBbDg

PR introduces (a) deprecation(s): no

Breaking changes

  • LatLngToJtsPointProcessor: Rename schema field WKT_RUNTIME to GEOMETRY_RUNTIME
  • ReprojectionProcessor: Rename schema field GEOM_RUNTIME to GEOMETRY_RUNTIME
  • TrajectoryFromPointsProcessor: Introduce schema field TRAJECTORY_GEOMETRY_RUNTIME and rename TRAJECTORY_RUNTIME to TRAJECTORY_EPSG_RUNTIME
  • HaversineDistanceCalculatorProcessor: Rename schema field CALCULATED_DISTANCE_KEY to DISTANCE_RUNTIME_NAME
  • SpeedCalculatorProcessor: Rename schema field SPEED_KEY to SPEED_RUNTIME_NAME

@flomickl flomickl linked an issue Feb 11, 2023 that may be closed by this pull request
Change Event Runtime Name of geometry field #1040
Closed
@github-actions github-actions bot added backend Everything that is related to the StreamPipes backend java Pull requests that update Java code pipeline elements Relates to pipeline elements labels Feb 11, 2023
@flomickl flomickl requested review from bossenti and tenthe February 11, 2023 21:33
@bossenti bossenti added the breaking change Indicates that a PR or issue yields to a breaking change label Feb 12, 2023
@bossenti bossenti changed the title [#1040] misc changes in runtime names, ad missing fields in schema [#1040] rework schema definitions in geo processors Feb 12, 2023
@flomickl flomickl requested a review from bossenti February 12, 2023 20:57
@flomickl
Copy link
Contributor Author

@bossenti ok to merge?

@bossenti
Copy link
Contributor

Sure, just go ahead :)

@flomickl flomickl merged commit 8f0a350 into dev Feb 18, 2023
@flomickl flomickl deleted the 1040-change-event-runtime-name-of-geometry-field branch February 18, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikriemer dominikriemer dominikriemer approved these changes

@bossenti bossenti bossenti approved these changes

@tenthe tenthe Awaiting requested review from tenthe

Assignees
No one assigned
Labels
backend Everything that is related to the StreamPipes backend breaking change Indicates that a PR or issue yields to a breaking change java Pull requests that update Java code pipeline elements Relates to pipeline elements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Event Runtime Name of geometry field
3 participants
@flomickl @bossenti @dominikriemer