Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-1704][SQL]java.lang.AssertionError: assertion failed: No plan for ExplainCommand (Project [*]) #963

Closed
wants to merge 1 commit into from

Conversation

yhuai
Copy link
Contributor

@yhuai yhuai commented Jun 4, 2014

No description provided.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@yhuai
Copy link
Contributor Author

yhuai commented Jun 4, 2014

@yhuai
Copy link
Contributor Author

yhuai commented Jun 4, 2014

Actually, the current version is not the right way. Will update it later.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15421/

lazy val queryExecution = sqlContext.executePlan(logicalPlan)
lazy val queryExecution =
logicalPlan match {
case ExplainCommand(plan) => sqlContext.executePlan(plan)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is really doing what we want it to do. This is just turning an explain command into the the query it is supposed to be explaining. Really, we should return the query plan.

Also, can we add a unit test to ensure we don't have a regression?

@yhuai yhuai closed this Jun 4, 2014
@yhuai yhuai deleted the SPARK-1704 branch June 4, 2014 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants