[SPARK-1820][tools] Make GenerateMimaIgnore @DeveloperApi annotation aware. #845
Conversation
|
Can one of the admins verify this patch? |
|
Jenkins, test this please. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15189/ |
| } | ||
|
|
||
| def classesAnnotationCheck(className: String) = { | ||
| try { |
There was a problem hiding this comment.
Please convert tabs to spaces (otherwise indentation looks really wack on github).
| for (className <- classes) { | ||
| val directlyPrivateSpark = isPackagePrivate(className) | ||
| val annotationCheck = classesAnnotationCheck(className) |
There was a problem hiding this comment.
It might be better to call this something like val developerApi to make it grammatically consistent with the other variables. I.e.
if (directlyPrivateSpark || indirectlyPrivateSpark || developerApi) privateClasses += className
|
I added some style feedback. This is failing several style tests: |
|
I've made the suggested changes... |
|
Jenkins, test this please. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15214/ |
|
Jenkins, test this please. Jenkins, this is okay to test. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15247/ |
|
#904 Fixes the build and few other style things. |
|
Can one of the admins verify this patch? |
|
@nikhils05 Can you close this PR ? |
|
Yeah let's close this issue for now. |
… MAPRSASL (apache#845) Co-authored-by: Egor Krivokon <>
… MAPRSASL (apache#845) Co-authored-by: Egor Krivokon <>
Solution for : Add all the classes with DeveloperApi annotation in Mima excludes.