-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-8621] [SQL] crosstab exception when one of the value is empty #7117
Conversation
Can one of the admins verify this patch? |
Can you add a regression test? |
Didn't get you @JoshRosen . Are not the crossTab tests already present in DataFrameStatSuite.scala? |
Yes but it looks like this patch fixes a bug without adding a test that could have reproduced / exposed that bug. The fact that there was a bug in the old code but no test failed suggests that our test coverage was insufficient. |
Maybe you have an unstaged test change that didn't get committed here? |
Okay will add a suitable test. |
cc @cloud-fan can you review this? thanks. |
Hi @animeshbaranawal , thanks for fixing this! |
improve the empty check in `parseAttributeName` so that we can allow empty string as column name. Close #7117 Author: Wenchen Fan <cloud0fan@outlook.com> Closes #7149 from cloud-fan/8621 and squashes the following commits: efa9e3e [Wenchen Fan] support empty string (cherry picked from commit 31b4a3d) Signed-off-by: Reynold Xin <rxin@databricks.com>
cc @rxin @marmbrus