[SPARK-7156][SQL] Addressed follow up comments for randomSplit #5795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
| @@ -445,7 +449,8 @@ def randomSplit(self, weights, seed=None): | |||
| 3 | |||
| """ | |||
| for w in weights: | |||
| assert w >= 0.0, "Negative weight value: %s" % w | |||
| if w < 0.0: | |||
| raise ValueError("Weights must be positive. Found weight value: %s" % w) | |||
There was a problem hiding this comment.
does %s work for numeric value?
There was a problem hiding this comment.
oh i checked on command line and it worked.
|
Test build #31354 has finished for PR 5795 at commit
|
|
Thanks. Merging in master. |
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
May 28, 2015
small fixes regarding comments in PR apache#5761 cc rxin Author: Burak Yavuz <brkyvz@gmail.com> Closes apache#5795 from brkyvz/split-followup and squashes the following commits: 369c522 [Burak Yavuz] changed wording a little 1ea456f [Burak Yavuz] Addressed follow up comments
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
small fixes regarding comments in PR apache#5761 cc rxin Author: Burak Yavuz <brkyvz@gmail.com> Closes apache#5795 from brkyvz/split-followup and squashes the following commits: 369c522 [Burak Yavuz] changed wording a little 1ea456f [Burak Yavuz] Addressed follow up comments
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
small fixes regarding comments in PR apache#5761 cc rxin Author: Burak Yavuz <brkyvz@gmail.com> Closes apache#5795 from brkyvz/split-followup and squashes the following commits: 369c522 [Burak Yavuz] changed wording a little 1ea456f [Burak Yavuz] Addressed follow up comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small fixes regarding comments in PR #5761
cc @rxin