Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some code clean up. #5794

Closed
wants to merge 2 commits into from
Closed

Some code clean up. #5794

wants to merge 2 commits into from

Conversation

dbtsai
Copy link
Member

@dbtsai dbtsai commented Apr 29, 2015

No description provided.

@rxin
Copy link
Contributor

rxin commented Apr 29, 2015

LGTM.

@SparkQA
Copy link

SparkQA commented Apr 30, 2015

Test build #31351 timed out for PR 5794 at commit 834d527 after a configured wait of 150m.

@rxin
Copy link
Contributor

rxin commented Apr 30, 2015

Jenkins, retest this please.

cloud-fan
cloud-fan reviewed Apr 30, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala
@@ -105,8 +105,7 @@ object LinearDataGenerator {
val x = Array.fill[Array[Double]](nPoints)(
Array.fill[Double](weights.length)(rnd.nextDouble()))

x.foreach {
case v =>
x.foreach { v =>
var i = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change the indent too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@SparkQA
Copy link

SparkQA commented Apr 30, 2015

Test build #31369 has finished for PR 5794 at commit 834d527.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@SparkQA
Copy link

SparkQA commented Apr 30, 2015

Test build #31375 has finished for PR 5794 at commit ad639dd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@rxin
Copy link
Contributor

rxin commented Apr 30, 2015

Thanks. I've merged this in master.

@asfgit asfgit closed this in ba49eb1 Apr 30, 2015
@dbtsai dbtsai deleted the clean branch April 30, 2015 16:49
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@jeanlyn
Some code clean up.
4584ee1 
Author: DB Tsai <dbt@netflix.com>

Closes apache#5794 from dbtsai/clean and squashes the following commits:

ad639dd [DB Tsai] Indentation
834d527 [DB Tsai] Some code clean up.
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@jeanlyn
Some code clean up.
9989053 
Author: DB Tsai <dbt@netflix.com>

Closes apache#5794 from dbtsai/clean and squashes the following commits:

ad639dd [DB Tsai] Indentation
834d527 [DB Tsai] Some code clean up.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@nemccarthy
Some code clean up.
42d2bc8 
Author: DB Tsai <dbt@netflix.com>

Closes apache#5794 from dbtsai/clean and squashes the following commits:

ad639dd [DB Tsai] Indentation
834d527 [DB Tsai] Some code clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbtsai @rxin @SparkQA @cloud-fan