[SPARK-6568] spark-shell.cmd --jars option does not accept the jar that has space in its path #5347
Conversation
…at has space in its path escape spaces in the arguments.
|
Test build #29664 has started for PR 5347 at commit |
|
This PR requires #5227 merged. (https://issues.apache.org/jira/browse/SPARK-6435) |
|
Test build #29664 has finished for PR 5347 at commit
|
|
Test FAILed. |
| @@ -1651,7 +1651,7 @@ private[spark] object Utils extends Logging { | |||
| /** | |||
| * Format a Windows path such that it can be safely passed to a URI. | |||
| */ | |||
| def formatWindowsPath(path: String): String = path.replace("\\", "/") | |||
| def formatWindowsPath(path: String): String = path.replace("\\", "/").replace(" ", "%20") | |||
There was a problem hiding this comment.
Hm, is this specific to Windows, even? if I had a path with a space on Linux it would fail similarly, I'd imagine? I bet we dont' get that case right either.
There was a problem hiding this comment.
Ah, forgot to consider Linux since I have hardly ever seen the path with spaces in Linux.
I'll move this code to somewhere else.
|
Sorry that I accidentally merged this PR instead of another one. I reverted the commit. So please reopen this PR and continue the discussion. |
|
OK, but is it available to reopen the merged pull request? I can't find the reopen button. |
|
New version #5447 is sent. |
escape spaces in the arguments.