Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-6688] [core] Always use resolved URIs in EventLoggingListener. #5340

Closed
wants to merge 2 commits into from
Closed

[SPARK-6688] [core] Always use resolved URIs in EventLoggingListener. #5340

wants to merge 2 commits into from

Conversation

vanzin
Copy link
Contributor

@vanzin vanzin commented Apr 3, 2015

No description provided.

andrewor14
andrewor14 reviewed Apr 3, 2015
View reviewed changes
core/src/main/scala/org/apache/spark/deploy/master/Master.scala
@@ -755,7 +755,7 @@ private[master] class Master(
}

val eventLogFilePrefix = EventLoggingListener.getLogPath(
eventLogDir, app.id, app.desc.eventLogCodec)
new URI(eventLogDir), app.id, app.desc.eventLogCodec)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this have to be resolveURI as well?

@andrewor14
Copy link
Contributor

@vanzin good catch. The changes here look good. On the other hand I was wondering if we should just resolve it in SparkContext in the first place and have sc.eventLogDir be an Option[URI]. Then we don't have to resolve it downstream and potentially leave out one or two places (as we did in Master.scala).

@SparkQA
Copy link

SparkQA commented Apr 3, 2015

Test build #29639 has finished for PR 5340 at commit 20d2a34.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

andrewor14
andrewor14 reviewed Apr 3, 2015
View reviewed changes
core/src/main/scala/org/apache/spark/deploy/master/Master.scala
@@ -18,7 +18,7 @@
package org.apache.spark.deploy.master

import java.io.FileNotFoundException
import java.net.URLEncoder
import java.net.{URI, URLEncoder}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't need to change. I'll fix this when I merge

@andrewor14
Copy link
Contributor

LGTM will merge into master and 1.3 once tests pass

@SparkQA
Copy link

SparkQA commented Apr 3, 2015

Test build #29682 has finished for PR 5340 at commit ccfddd9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

asfgit pushed a commit that referenced this pull request Apr 3, 2015
[SPARK-6688] [core] Always use resolved URIs in EventLoggingListener.
f17a2fe 
Author: Marcelo Vanzin <vanzin@cloudera.com>

Closes #5340 from vanzin/SPARK-6688 and squashes the following commits:

ccfddd9 [Marcelo Vanzin] Resolve at the source.
20d2a34 [Marcelo Vanzin] [SPARK-6688] [core] Always use resolved URIs in EventLoggingListener.

(cherry picked from commit 14632b7)
Signed-off-by: Andrew Or <andrew@databricks.com>
@asfgit asfgit closed this in 14632b7 Apr 3, 2015
@vanzin vanzin deleted the SPARK-6688 branch April 14, 2015 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vanzin @andrewor14 @SparkQA