[SQL][Minor] Use analyzed logical instead of unresolved in HiveComparisonTest #4946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #28386 has started for PR 4946 at commit
|
|
Test build #28386 has finished for PR 4946 at commit
|
|
Test PASSed. |
|
Merged to master. |
| @@ -296,7 +296,7 @@ abstract class HiveComparisonTest | |||
|
|
|||
| val hiveQueries = queryList.map(new TestHive.HiveQLQueryExecution(_)) | |||
| // Make sure we can at least parse everything before attempting hive execution. | |||
| hiveQueries.foreach(_.logical) | |||
| hiveQueries.foreach(_.analyzed) | |||
There was a problem hiding this comment.
This change breaks golden answer generation. You can't analyze queries unless you are also executing DDL from previous queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some internal unit test failed due to the logical plan node in pattern matching in
HiveComparisonTest, e.g.https://github.com/apache/spark/blob/master/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala#L137
Which will may call the
outputfunction on an unresolved logical plan.