[GraphX] Improve LiveJournalPageRank example #4917
Conversation
jackylk
commented
Mar 5, 2015
jackylk
commented
- Removed unnecessary import
- Modified usage print since user must specify the --numEPart parameter as it is required in Analytics.main
|
Test build #28299 has started for PR 4917 at commit
|
| @@ -17,11 +17,6 @@ | |||
|
|
|||
| package org.apache.spark.examples.graphx | |||
|
|
|||
| import org.apache.spark.SparkContext._ | |||
There was a problem hiding this comment.
Are you sure you can remove this one? it imports implicits right?
This change loses the description of the parameter too.
This is on the border of non-trivial, but if it's merely fixing the usage note, seems OK.
There was a problem hiding this comment.
Yes, I think it is OK.
The description of the parameter will be output by the Analytics.Main, looks like:
JackydeMacBook-Pro:spark jackylee$ bin/run-example graphx.LiveJournalPageRank ../data/Wiki-Vote.txt
Set the number of edge partitions using --numEPart.
Using Spark's default log4j profile: org/apache/spark/log4j-defaults.properties
JackydeMacBook-Pro:spark jackylee$
There was a problem hiding this comment.
Yes, but, why remove the description, which already existed in the help message in this file?
There was a problem hiding this comment.
Yes, you are right. I modified back, just remove the default value description
|
Test build #28299 has finished for PR 4917 at commit
|
|
Test PASSed. |
|
Test build #28319 has started for PR 4917 at commit
|
|
Test build #28319 has finished for PR 4917 at commit
|
|
Test PASSed. |
| " [--tol=<tolerance>]\n" + | ||
| " The tolerance allowed at convergence (smaller => more accurate). Default is " + | ||
| "0.001.\n" + | ||
| " [--output=<output_file>]\n" + | ||
| " If specified, the file to write the ranks to.\n" + | ||
| " [--numEPart=<num_edge_partitions>]\n" + | ||
| " The number of partitions for the graph's edge RDD. Default is 4.\n" + | ||
| " The number of partitions for the graph's edge RDD.\n" + |
There was a problem hiding this comment.
Eh, but now you have put the option in twice! why not just move it up and remove the square braces to mark it non-optional? keep everything else the same.
|
Test build #28369 has started for PR 4917 at commit
|
|
Test build #28369 has finished for PR 4917 at commit
|
|
Test FAILed. |
|
Test build #28370 has started for PR 4917 at commit
|
|
Test build #28370 has finished for PR 4917 at commit
|
|
Test FAILed. |
| @@ -60,6 +60,9 @@ fi | |||
| # | |||
| # For backwards-compatibility, we retain the old IPYTHON and IPYTHON_OPTS variables. | |||
|
|
|||
| export PYSPARK_DRIVER_PYTHON=ipython | |||
There was a problem hiding this comment.
OK, but now there is this unrelated change in your PR.
|
Test build #28373 has started for PR 4917 at commit
|
|
Test build #28373 has finished for PR 4917 at commit
|
|
Test PASSed. |
